Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: Assert that there are streams available in EnvoyQuicClientSession::OnCanCreateNewOutgoingStream #18786

Closed
wants to merge 2 commits into from
Closed

quic: Assert that there are streams available in EnvoyQuicClientSession::OnCanCreateNewOutgoingStream #18786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3bb45
quic: Tighten an assert in EnvoyQuicClientSession::streamsAvailable
RyanTheOptimist Oct 26, 2021
54b145a
Better ASSERT
RyanTheOptimist Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/common/quic/envoy_quic_client_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ void EnvoyQuicClientSession::OnCanCreateNewOutgoingStream(bool unidirectional) {
return;
}
uint32_t streams_available = streamsAvailable();
ASSERT(streams_available > 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't think we want this because it's not going to play well with my PR in progress, where we artificially call OnCanCreate... to update the conn pool when we complete handshake even if there's no streams. I alternately we can change that PR to manually onMaxStreamsChanged but I mildly prefer just not adding this assert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I came to that conclusion as well in my previous comment. C'est la vie :) I'll close this out.

if (streams_available > 0) {
http_connection_callbacks_->onMaxStreamsChanged(streams_available);
}
Expand Down