Fix crash-on-startup on macOS 12 #18779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gperftools_tcmalloc is not compatible with macOS 12, resulting in a crash on startup. The crash happens very early, before CLI args are parsed. Fixes envoyproxy#17535 Signed-off-by: Greg Greenway <[email protected]>
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Oct 26, 2021
I thought about it, and decided it wasn't worth it; I don't think anybody cares which malloc is used. |
|
Could you release this as soon as possible? We really need this..... Thank you so much |
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Nov 2, 2021
gperftools_tcmalloc is not compatible with macOS 12, resulting in a crash on startup. The crash happens very early, before CLI args are parsed. Fixes envoyproxy#17535 Signed-off-by: Greg Greenway <[email protected]> (cherry picked from commit b9939c6)
alyssawilk
pushed a commit
that referenced
this pull request
Nov 2, 2021
gperftools_tcmalloc is not compatible with macOS 12, resulting in a crash on startup. The crash happens very early, before CLI args are parsed. Fixes #17535 (cherry picked from commit b9939c6) Signed-off-by: Greg Greenway <[email protected]>
|
Bug still present? |
aidanhahn
pushed a commit
to datawire/envoy
that referenced
this pull request
Jan 13, 2022
gperftools_tcmalloc is not compatible with macOS 12, resulting in a crash on startup. The crash happens very early, before CLI args are parsed. Fixes envoyproxy#17535 (cherry picked from commit b9939c6) Signed-off-by: Greg Greenway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17535
Signed-off-by: Greg Greenway [email protected]
Commit Message: gperftools_tcmalloc is not compatible with macOS 12, resulting in a
crash on startup. The crash happens very early, before CLI args are
parsed.
Additional Description:
Risk Level: Low
Testing: Manually built and verified it launches
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: macOS only fix
[Optional Runtime guard:]
Fixes #17535
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]