bazel: fix typo in external_deps.bzl

[JamesHeppenstall]

Signed-off-by: James Heppenstall [email protected]

Commit Message: bazel: fix typo in external_deps.bzl
Additional Description: N/A
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Question: I also see here that the preferred way of adding external dependencies that use CMake is to add a cmake_external rule but there are no references to cmake_external in the codebase. Instead, there a various envoy_cmake references. Should the documentation be updated?

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18771 was opened by JamesHeppenstall.

see: more, trace.

[phlax]

lgtm, thanks @JamesHeppenstall

[JamesHeppenstall]

lgtm, thanks @JamesHeppenstall

Thanks for the quick lgtm @phlax. Was wondering if you knew the answer to my question/whether an update needs to be made?

[phlax]

Was wondering if you knew the answer to my question...

not off hand, checking through, i can see the definition for envoy_cmake makes a call to the cmake rule (rather than cmake_external )

almost certainly those instructions need to be updated, to make them less confusing if nothing else

can i suggest opening an issue for that, we can cc others that probably know better if you do

[JamesHeppenstall]

Was wondering if you knew the answer to my question...

not off hand, checking through, i can see the definition for envoy_cmake makes a call to the cmake rule (rather than cmake_external )

almost certainly those instructions need to be updated, to make them less confusing if nothing else

can i suggest opening an issue for that, we can cc others that probably know better if you do

Opened an issue as suggested 😄

[phlax]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18771 (comment) was created by @phlax.

see: more, trace.

[phlax]

cc @moderation for deps approval

[moderation]

/lgtm deps