Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: copy .bazelversion for envoy filter examples #18730

Merged
merged 2 commits into from
Oct 27, 2021
Merged

bazel: copy .bazelversion for envoy filter examples #18730

merged 2 commits into from
Oct 27, 2021

Conversation

keith
Copy link
Member

@keith keith commented Oct 22, 2021

This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley [email protected]

@keith
bazel: copy .bazelversion for envoy filter examples
a608511 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
@keith keith mentioned this pull request Oct 22, 2021
Closed
3 tasks
@phlax phlax self-assigned this Oct 22, 2021
@phlax
Copy link
Member

phlax commented Oct 22, 2021

cc @lizan

@keith
Remove first
d66fed1 
Signed-off-by: Keith Smiley <[email protected]>
@keith
Copy link
Member Author

keith commented Oct 22, 2021

oh it's more complicated than this. that repo has a symlink to bazelversion from the submodule of envoy https://github.com/envoyproxy/envoy-filter-example/blob/main/.bazelversion

Interesting circular dependency for updating it since the tests here rely on that. I removed that version here now, which might work, but that doesn't feel right either if it actually does reference bazel files from the submodule

@phlax
Copy link
Member

phlax commented Oct 22, 2021 •
edited
Loading

Interesting circular dependency for updating it since the tests...

this seems to be a bit of an endemic problem

ideally using a third party repo - ie envoy-build-tools should resolve and provide an authoritative version, but atm we seem to be just adding more places where versions are specified

im wondering if there is some automation/validation we can add in consuming CI to ensure that there is only one place where version/s need to be specified, and consumers check/copy/enforce versions from whereever we decide is authoritative (<-- as a general approach that we do more often)

@phlax
Copy link
Member

phlax commented Oct 22, 2021

(i guess this PR is ~doing what i suggested, but this kinda problem seems to happen with quite a few deps)

@keith
Copy link
Member Author

keith commented Oct 22, 2021

yea, I could still see this having issues if that repo actually references bazel files from the submodule, if they also had to be updated to be compatible

@phlax
Copy link
Member

phlax commented Oct 22, 2021

if they also had to be updated to be compatible

hmm, yep https://github.com/envoyproxy/envoy-filter-example doesnt seem to have much in the way of CI and/or i guess pinning to version/s

@phlax phlax enabled auto-merge (squash) October 27, 2021 14:00
@phlax
Copy link
Member

phlax commented Oct 27, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18730 (comment) was created by @phlax.

see: more, trace.

@phlax phlax merged commit 723ed18 into envoyproxy:main Oct 27, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 29, 2021
@mpuncel
Merge branch 'main' into mpuncel/hc-after-sds-init-manager
65ef40c 
* main: (221 commits)
  deps: Bump `protobuf` -> 3.19.0 (envoyproxy#18471)
  tooling: auto-assign dependency shephards (envoyproxy#18794)
  clang-tidy: Return from diff fun if empty diff (envoyproxy#18815)
  repokitteh: Block PRs pending deps approval (envoyproxy#18814)
  deps: Bump `org_llvm_llvm` -> 12.0.1, `com_github_wavm_wavm` -> 9ffd3e2 (envoyproxy#18747)
  dns resolvers: add All lookup mode (envoyproxy#18464)
  doc: fix link formatting for TLS session_timeout (envoyproxy#18790)
  ext_authz: Set response flag and code details to UAEX when denied (envoyproxy#18740)
  socket options: add support for directly creating ipv4/ipv6 pairs (envoyproxy#18769)
  ecds: make onConfigUpdate generic over filter type (envoyproxy#18061)
  bazel: update CMake instructions in EXTERNAL_DEPS.md (envoyproxy#18799)
  upstream: fix typo in comment (envoyproxy#18798)
  runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits (envoyproxy#18696)
  bazel: Add CC=clang to clang configuration (envoyproxy#18732)
  fix error request id in the dubbbo local reply (envoyproxy#18741)
  event: assert the case of both read and closed event registered (envoyproxy#18265)
  tcp proxy connect tunneling: improved testing (envoyproxy#18784)
  deps: Bump `protoc-gen-validate` -> 0.6.2 (envoyproxy#18742)
  deps: Bump `rules_pkg` -> ad57589 (envoyproxy#18746)
  bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
  ...

Signed-off-by: Michael Puncel <[email protected]>
yanavlasov pushed a commit to yanavlasov/envoy that referenced this pull request Feb 17, 2022
@keith @yanavlasov
bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
af32058 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov pushed a commit to yanavlasov/envoy that referenced this pull request Feb 17, 2022
@keith @yanavlasov
bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
201e924 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov pushed a commit to yanavlasov/envoy that referenced this pull request Feb 17, 2022
@keith @yanavlasov
bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
3ebdd77 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov added a commit that referenced this pull request Feb 17, 2022
@yanavlasov @keith
bazel: copy .bazelversion for envoy filter examples (#18730) (#20010)
f6f7ea0 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>

Co-authored-by: Keith Smiley <[email protected]>
alyssawilk pushed a commit that referenced this pull request Feb 17, 2022
@yanavlasov @keith
bazel: copy .bazelversion for envoy filter examples (#18730) (#20012)
a3a8c81 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>

Co-authored-by: Keith Smiley <[email protected]>
alyssawilk pushed a commit that referenced this pull request Feb 17, 2022
@yanavlasov @keith
bazel: copy .bazelversion for envoy filter examples (#18730) (#20011)
ff19a7a 
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release

Signed-off-by: Keith Smiley <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>

Co-authored-by: Keith Smiley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizan lizan lizan approved these changes

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @phlax @lizan