Integrate rapidjson into ci #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
reviewed
Nov 2, 2016
| @@ -131,4 +131,7 @@ wget -O gcovr-3.3.tar.gz https://github.com/gcovr/gcovr/archive/3.3.tar.gz | |||
| tar xf gcovr-3.3.tar.gz | |||
| rm gcovr-3.3.tar.gz | |||
|
|
|||
|
|
|||
| # rapidjson | |||
There was a problem hiding this comment.
move before test dependencies
mattklein123
reviewed
Nov 2, 2016
|
|
||
| # https://github.com/miloyip/rapidjson | ||
| # Last tested with 1.1.0 | ||
| set(ENVOY_RAPIDJSON_INCLUDE_DIR "" CACHE FILEPATH "location of rapidjson includes") |
There was a problem hiding this comment.
move before test dependencies
|
@lyft/network-team |
mattklein123
approved these changes
Nov 2, 2016
| @@ -50,6 +50,10 @@ set(ENVOY_LIGHTSTEP_TRACER_INCLUDE_DIR "" CACHE FILEPATH "location of lighstep t | |||
| # Extra linker flags required to properly link envoy with all of the above libraries. | |||
| set(ENVOY_EXE_EXTRA_LINKER_FLAGS "" CACHE STRING "envoy extra linker flags") | |||
|
|
|||
| # https://github.com/miloyip/rapidjson | |||
There was a problem hiding this comment.
nit: can you group code dependency in one place? (just place this before extra linker flags)
|
lgtm, one small comment |
gargnupur
added a commit
to gargnupur/envoy
that referenced
this pull request
Mar 20, 2020
* Fix memory leak in TCP Signed-off-by: gargnupur <[email protected]> * fix lint Signed-off-by: gargnupur <[email protected]>
PiotrSikora
added a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Piotr Sikora <[email protected]>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…ubsets zh-translation: /intro/arch_overview/upstream/load_balancing/subsets.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino [email protected] Description: add spelling pre-commit hook. Note that I did not go with the tools in upstream because they are more entrenched in the organization of the upstream project. This suffices for now. Also note that none of the solutions (this one, or the ones upstream -- misspell, aspell) are 100% great; meaning that let through a significant amount of misspellings. For instance, enfornced was not caught by any of the solutions. Risk Level: low -- new pre-commit hook. Testing: ran locally. Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino [email protected] Description: add spelling pre-commit hook. Note that I did not go with the tools in upstream because they are more entrenched in the organization of the upstream project. This suffices for now. Also note that none of the solutions (this one, or the ones upstream -- misspell, aspell) are 100% great; meaning that let through a significant amount of misspellings. For instance, enfornced was not caught by any of the solutions. Risk Level: low -- new pre-commit hook. Testing: ran locally. Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.