Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: v2 Address resolution using named resolver #1835

Merged
merged 16 commits into from
Oct 13, 2017
Merged

config: v2 Address resolution using named resolver #1835

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a0c1ef2
Add logicalName() to Network::Address interface
akonradi Oct 9, 2017
b3ea367
Add Address::Resolver interface
akonradi Oct 10, 2017
bc87db0
Add Address::Resolver for IP resolution
akonradi Oct 10, 2017
3ed3f63
Make RegisterFactory remove factory on delete
akonradi Oct 10, 2017
0a7f987
Move Network::Utility proto address parsing
akonradi Oct 10, 2017
c0cac0b
Make Address::Resolver take a proto to resolve
akonradi Oct 11, 2017
9451f07
Fix documentation in comments.
akonradi Oct 11, 2017
a633aaf
Change ResolverFactory::create() to createResolver
akonradi Oct 11, 2017
134034c
Add tests to cover address resolution error cases
akonradi Oct 11, 2017
de0ee8e
Check exception message for IP with named port
akonradi Oct 11, 2017
aa73c50
Make resolver name method const
akonradi Oct 12, 2017
0236b12
Remove ResolverFactory from address resolution
akonradi Oct 12, 2017
915c7d3
Use EXPECT_THROW_WITH_MESSAGE for resolver tests
akonradi Oct 12, 2017
594721d
Add missing 'override's to Address::Resolver impls
akonradi Oct 12, 2017
e6e8cc9
Add TODO for registry injection once that's done
akonradi Oct 13, 2017
16d8e5d
Make test TODO more detailed
akonradi Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/common/network/resolver_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class TestResolver : public Resolver {
};

TEST(ResolverTest, NonStandardResolver) {
// TODO(akonradi) Use singleton override for this test once #1808 is resolved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and get rid of the need to unregister factories...

Registry::RegisterFactory<TestResolver, Resolver> register_resolver;
auto& test_resolver = register_resolver.testGetFactory();
test_resolver.addMapping("foo", "1.2.3.4");
Expand Down