Revert "bazel: update rules_foreign_cc" #17875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
@keith you need to fix DCO, not sure if the other errors are genuine |
)" (envoyproxy#17780)" (envoyproxy#17799)" This reverts commit 4b3f4a5. Signed-off-by: Keith Smiley <[email protected]>
keith
force-pushed
the
revert-17799-ks/revert-revert-bazel-update-rules_foreign_cc-17445-17780
branch
from
c38dc5f to
fd1503c
Compare
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Aug 27, 2021
keith
deleted the
revert-17799-ks/revert-revert-bazel-update-rules_foreign_cc-17445-17780
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17799
Seems like this wasn't enough yet again envoyproxy/envoy-mobile#1754
Signed-off-by: Keith Smiley [email protected]