Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Clarify that RouteMatch.case_sensitive field does not apply to safe_regex #17176

Merged
merged 1 commit into from
Jun 29, 2021
Merged

xds: Clarify that RouteMatch.case_sensitive field does not apply to safe_regex #17176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/envoy/config/route/v3/route_components.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ message RouteMatch {
}

// Indicates that prefix/path matching should be case sensitive. The default
// is true.
// is true. Ignored for safe_regex matching.
google.protobuf.BoolValue case_sensitive = 4;

// Indicates that the route should additionally match on a runtime key. Every time the route
Expand Down
2 changes: 1 addition & 1 deletion api/envoy/config/route/v4alpha/route_components.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated_api_shadow/envoy/config/route/v3/route_components.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated_api_shadow/envoy/config/route/v4alpha/route_components.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.