Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex: remove parseStdRegexAsCompiledMatcher #17061

Merged
merged 1 commit into from
Jun 21, 2021
Merged

regex: remove parseStdRegexAsCompiledMatcher #17061

merged 1 commit into from
Jun 21, 2021

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai [email protected]

Commit Message:

Remove useless func, now it is only used in test:

root:[envoy]$ git grep parseStdRegexAsCompiledMatcher
source/common/common/regex.cc:130:CompiledMatcherPtr Utility::parseStdRegexAsCompiledMatcher(const std::string& regex,
source/common/common/regex.h:36:  parseStdRegexAsCompiledMatcher(const std::string& regex,
test/common/common/regex_test.cc:20:  EXPECT_THROW_WITH_REGEX(Utility::parseStdRegexAsCompiledMatcher("(+invalid)"), EnvoyException,
test/common/common/regex_test.cc:38:    auto matcher = Utility::parseStdRegexAsCompiledMatcher(

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

alyssawilk
alyssawilk approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@alyssawilk alyssawilk merged commit e949791 into envoyproxy:main Jun 21, 2021
@daixiang0 daixiang0 deleted the parse branch June 22, 2021 00:26
@davinci26 davinci26 mentioned this pull request Jun 29, 2021
Merged
alyssawilk pushed a commit that referenced this pull request Jul 1, 2021
Increase common/common coverage (#17193)
7da9989 
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher #17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <[email protected]>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
@chrisxrepo
Increase common/common coverage (envoyproxy#17193)
fe87bb1 
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: chris.xin <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@daixiang0
regex: remove parseStdRegexAsCompiledMatcher (envoyproxy#17061)
6c171f4 
Remove useless func, now it is only used in test:

Signed-off-by: Long Dai <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Increase common/common coverage (envoyproxy#17193)
ae1e96e 
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssawilk alyssawilk alyssawilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daixiang0 @alyssawilk