ci: support custom TEST_TMPDIR and clang-format

[daixiang0]

Signed-off-by: Long Dai [email protected]

Commit Message:

Fix hardcode val for TEST_TMPDIR and llvm.

Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

[jmarantz]

Drive-by comment: what's broken about the current support for TEST_TMPDIR and clang-format?

[rgs1]

Drive-by comment: what's broken about the current support for TEST_TMPDIR and clang-format?

I think it's probably two things:

a) being able to set TEST_TMPDIR externally (at call time maybe)

export TEST_TMPDIR="${TEST_TMPDIR:-BUILD_DIR/tmp}"

b) This ensures LLVM's binaries are actually in $PATh

export LLVM_ROOT="${LLVM_ROOT:-/opt/llvm}"
export PATH=${LLVM_ROOT}/bin:${PATH}

[rgs1]

This looks reasonable to me, once CI passes.

[daixiang0]

@jmarantz thanks for quick comment.
@rgs1 yep, what you said is what I mean!

[daixiang0]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17020 (comment) was created by @daixiang0.

see: more, trace.

[phlax]

lgtm, thanks @daixiang0