Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Consolidate docs tooling requirements #16956

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 13, 2021

Signed-off-by: Ryan Northey [email protected]

Commit Message: docs: Consolidate docs tooling requirements
Additional Description:

This is a breakout from #15229

It consolidates the 2 requirements.txt files currently in /docs/ and /tools/docs -> just /tools/docs

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16956 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 13, 2021
@phlax
Copy link
Member Author

phlax commented Jun 13, 2021

--allow-unsafe is added to the pip-compile command as when installing sphinx with bazel (in #15229) its forcing a setuptools upgrade

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 14, 2021
@lizan lizan merged commit 6246f6b into envoyproxy:main Jun 18, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants