protos: Remove unused proto import

[phlax]

Signed-off-by: Ryan Northey [email protected]

Commit Message: protos: Remove unused proto import
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #16834 was opened by phlax.

see: more, trace.

[daixiang0]

I am wondering is there a tool to check unused proto import?

[phlax]

I am wondering is there a tool to check unused proto import?

not afaiaa but i would be very happy to be corrected

see #15589 for related discussion

[daixiang0]

Happy to see those clean :)

[htuch]

@phlax can you add to CI some auto-detection of these warnings and then we can prevent regression? I don't mind approving this, but ideally we automate ourselves out of our job here.

[phlax]

can you add to CI some auto-detection of these warnings

@htuch not trivially as explained before - the obvious way would be to fail on warning - but bazel rules_proto emits useless warnings about missing directories which massively complicates that

here is our tracking ticket #15589

and here is me moaning on the very aged upstream ticket about lack of progress bazelbuild/bazel#7157 (comment)

i guess there are some hacky workarounds - but its pretty annoying because i think the proper fix should be fairly trivial

[phlax]

one thing i would also say is that i was cleaning up 2-3 of these per week - but fixing the docs seems to have reduced this down to 1 or 2 a month

[htuch]

I was thinking something like tee-ing the output somewhere and grepping for the specific unused import warnings. I don't mind merging, but I rather not whackamole longer term.