-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stat_sinks: remove well_known_names #16794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@envoyproxy/senior-maintainers
Please merge main. /wait |
@mattklein123 done, sorry for rebase :( |
In the future, please try to avoid force-pushing in Envoy PRs; it makes it harder to follow the comment history. |
@jmarantz I would take care of it, thanks for review! |
Don't rebase either. Below is what I do. I have to admit I am using git in the most basic way. I stay on a narrow path that limits me quite a bit in taking advantage of what git can do, but it seems to work for me :) This is a script I call
Why is this mess better than rebase/force-push? I don't know the answer to that deep question, except that rebase/force-push is very unfriendly to the github review flow, and the above works fine for me. |
Good script! I will do it. Thank you a lot @jmarantz Update, since the last merge push, my commit log becomes wired :( I would fix it by force push to remove others' commits, sorry again! |
Signed-off-by: Long Dai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wait
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai <[email protected]>
/wait |
/wait |
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai [email protected]
Commit Message:
Remove well_known_names in stat_sinks field, part of #7238
Additional Description:
Additional Description:
Risk Level: Low
Testing: functional
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]