Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat_sinks: remove well_known_names #16794

Merged
merged 11 commits into from
Jul 20, 2021
Merged

stat_sinks: remove well_known_names #16794

merged 11 commits into from
Jul 20, 2021

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai [email protected]

Commit Message:

Remove well_known_names in stat_sinks field, part of #7238

Additional Description:
Additional Description:
Risk Level: Low
Testing: functional
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

jmarantz
jmarantz previously approved these changes Jun 3, 2021
Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@envoyproxy/senior-maintainers

test/extensions/stats_sinks/dog_statsd/config_test.cc Outdated Show resolved Hide resolved
@mattklein123
Copy link
Member

Please merge main.

/wait

@daixiang0
Copy link
Member Author

daixiang0 commented Jul 7, 2021

@mattklein123 done, sorry for rebase :(

@jmarantz
Copy link
Contributor

jmarantz commented Jul 7, 2021

In the future, please try to avoid force-pushing in Envoy PRs; it makes it harder to follow the comment history.

@daixiang0
Copy link
Member Author

@jmarantz I would take care of it, thanks for review!

@jmarantz
Copy link
Contributor

jmarantz commented Jul 8, 2021

Don't rebase either. Below is what I do. I have to admit I am using git in the most basic way. I stay on a narrow path that limits me quite a bit in taking advantage of what git can do, but it seems to work for me :)

This is a script I call git-sync.

#!/bin/sh

function die() {
    echo $@
    exit 1
}

git status | grep -q "nothing to commit" || die "Uncommitted changes exist"

branch=$(git status|head -1|cut -f3 -d\ )
git checkout main
git fetch upstream
git reset --hard upstream/main
git push origin main --force --no-verify
git checkout "$branch"
git merge main

Why is this mess better than rebase/force-push? I don't know the answer to that deep question, except that rebase/force-push is very unfriendly to the github review flow, and the above works fine for me.

@daixiang0
Copy link
Member Author

daixiang0 commented Jul 12, 2021

Good script! I will do it. Thank you a lot @jmarantz

Update, since the last merge push, my commit log becomes wired :(
Even with your script, still cover others' commits.

I would fix it by force push to remove others' commits, sorry again!

Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

test/extensions/stats_sinks/dog_statsd/config_test.cc Outdated Show resolved Hide resolved
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Long Dai <[email protected]>
@jmarantz
Copy link
Contributor

/wait

@jmarantz
Copy link
Contributor

/wait

@mattklein123 mattklein123 removed their assignment Jul 16, 2021
@snowp snowp merged commit 1f752f0 into envoyproxy:main Jul 20, 2021
@daixiang0 daixiang0 deleted the stat branch July 21, 2021 00:36
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants