Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal_redirect: remove well_known_names #16746

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai [email protected]

Commit Message:

Remove well_known_names in internal_redirect field, part of #7238

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Will merge as is but next time mind filling out the PR template for easier merging?

@alyssawilk alyssawilk merged commit 1c03ddc into envoyproxy:main Jun 1, 2021
@daixiang0
Copy link
Member Author

@alyssawilk got it, thanks for kind input

@daixiang0 daixiang0 deleted the internal_redirect branch June 2, 2021 00:25
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Long Dai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants