Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_credentials: remove well_known_names #16693

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai [email protected]

Commit Message:

Remove weel_known_names in grpc_credentials field, part of #7238

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@dmitri-d
Copy link
Contributor

source/extensions/grpc_credentials/well_known_names.h (and similar in other PRs) acted as a sort of docs for the format of factory names. Is this documented elsewhere (I didn't see at a quick glance)? Should the format be documented, perhaps here: https://github.com/envoyproxy/envoy/blob/main/include/envoy/config/typed_config.h#L22? There's a comment there, but I don't think it's sufficient...

@mattklein123
Copy link
Member

source/extensions/grpc_credentials/well_known_names.h (and similar in other PRs) acted as a sort of docs for the format of factory names. Is this documented elsewhere (I didn't see at a quick glance)? Should the format be documented, perhaps here: https://github.com/envoyproxy/envoy/blob/main/include/envoy/config/typed_config.h#L22? There's a comment there, but I don't think it's sufficient...

+1 let's do a follow up PR somewhere to document expectations here. Perhaps also here: https://github.com/envoyproxy/envoy/blob/main/EXTENSION_POLICY.md

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 5b9b53e into envoyproxy:main May 27, 2021
@daixiang0 daixiang0 deleted the grpc branch May 28, 2021 07:31
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants