Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix merge breakage #16597

Merged
merged 1 commit into from
May 20, 2021
Merged

test: fix merge breakage #16597

merged 1 commit into from
May 20, 2021

Conversation

alyssawilk
Copy link
Contributor

No description provided.

Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk
Copy link
Contributor Author

(the unit test in #16569 didn't play well with lazy-cert loading in #16462)

This fixes by loading fake secrets in the unit tests, and not returning (and dereferencing) a null session.

@alyssawilk alyssawilk merged commit 2b9fb47 into envoyproxy:main May 20, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@alyssawilk alyssawilk deleted the mergefix branch February 28, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants