[fuzz]: fix oss fuzz 32643, Config validation of lb_subset_config for server fuzz test #16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2021 19:54
Signed-off-by: chaoqin-li1123 <[email protected]>
Signed-off-by: chaoqin-li1123 <[email protected]>
chaoqin-li1123
changed the title
|
Could you please add the monorail bug as well? |
Signed-off-by: chaoqin-li1123 <[email protected]>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
… server fuzz test (envoyproxy#16582) * misconfiguration of subset_selectors will cause the test to failed. reject such misconfiguration to prevent the fuzz test failure. Signed-off-by: chaoqin-li1123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: In server fuzz test, misconfiguration of subset_selectors will cause the test to failed.(https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32643) When we set single_host_per_subset to be true and specify more than 1 key, envoy will throw unexpected exception. Since the correct configuration of subset_selectors is well documented, we can reject such misconfiguration to prevent the fuzz test failure.
Additional Description:
Risk Level: low
Testing: add config validation to server fuzz test.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]