Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix format issue #16555

Merged
merged 1 commit into from
May 19, 2021
Merged

docs: fix format issue #16555

merged 1 commit into from
May 19, 2021

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai [email protected]

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:

Fix format issue to pass pre-push check.

Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16555 (comment) was created by @daixiang0.

see: more, trace.

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16555 (comment) was created by @daixiang0.

see: more, trace.

Signed-off-by: Long Dai <[email protected]>
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wbpcode
Copy link
Member

wbpcode commented May 19, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16555 (comment) was created by @wbpcode.

see: more, trace.

@phlax phlax self-assigned this May 19, 2021
@phlax
Copy link
Member

phlax commented May 19, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16555 (comment) was created by @phlax.

see: more, trace.

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16555 (comment) was created by @daixiang0.

see: more, trace.

@PiotrSikora
Copy link
Contributor

PiotrSikora commented May 19, 2021

This is not a flake, retesting it over and over again won't help:

Code coverage for source/common/quic is lower than limit of 88.4 (87.8)

Broken in #16522 or #16534.

@phlax
Copy link
Member

phlax commented May 19, 2021

This is not a flake

as we now have 2 permafails on main someone with override CI power needs to land a fix to one or other first

@alyssawilk alyssawilk merged commit cc24391 into envoyproxy:main May 19, 2021
@daixiang0 daixiang0 deleted the order branch May 20, 2021 01:15
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Fix format issue to pass pre-push check.

Signed-off-by: Long Dai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants