-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions: Consolidate configuration #16496
Conversation
/retest |
Retrying Azure Pipelines: |
1c85b30
to
bade3aa
Compare
@htuch - quick summary there is a remaining issue on what to do with the validation checks that previously happened in the bazel macro - i can either readd by adding extensions names to source bazel build files - or we can validate these in i have added a regression test for there is an override related to this im noticing that other repos also use or override the
not sure how these will be affected by changing the format of the config in this way - im happy to open downstream PRs to fix if necessary im also noticing that there are some dev docs that will need to be updated... |
re breaking https://github.com/envoyproxy/envoy-mobile - i have opened a ticket here envoyproxy/envoy-mobile#1475 to resolve re breaking https://github.com/GoogleCloudPlatform/esp-v2 - this seems to be quite a way behind envoy |
/retest |
Retrying Azure Pipelines: |
e7838aa
to
fe150f0
Compare
Signed-off-by: Ryan Northey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Like seeing the wall of red.
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey [email protected]
Commit Message: extensions: Consolidate configuration
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]