http3: applied cluster buffer limits to http/3 #16466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
danzh2010
reviewed
May 12, 2021
| auto ret = std::make_unique<EnvoyQuicClientSession>( | ||
| info_impl->quic_config_, info_impl->supported_versions_, std::move(connection), | ||
| info_impl->server_id_, info_impl->crypto_config_.get(), &static_info.push_promise_index_, | ||
| dispatcher, /*send_buffer_limit=*/0); | ||
| dispatcher, info_impl->buffer_limit_); |
There was a problem hiding this comment.
Mind adding some conn_pool tests for this?
danzh2010
reviewed
May 12, 2021
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
danzh2010
reviewed
May 12, 2021
| quiche::FlagRegistry::getInstance(); | ||
| } | ||
|
|
||
| namespace { | ||
| // TODO(alyssawilk, danzh2010): This is mutable static info that is required for the QUICHE code. | ||
|
|
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
|
@snowp mind doing !googler pass? |
snowp
suggested changes
May 17, 2021
|
|
||
| NiceMock<Event::MockDispatcher> dispatcher_; | ||
| std::shared_ptr<Upstream::MockClusterInfo> cluster_{new NiceMock<Upstream::MockClusterInfo>()}; | ||
| Upstream::MockHost* mock_host = new NiceMock<Upstream::MockHost>; |
There was a problem hiding this comment.
Naming convention seems off for this field. Maybe just combine this and host_ into one field and avoid the raw pointer?
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
|
Done. Any other requests? |
danzh2010
previously approved these changes
May 19, 2021
| } | ||
| }; | ||
|
|
||
| TEST_F(QuicNetworkConnectionTest, BufferLimits) { |
Signed-off-by: Alyssa Wilk <[email protected]>
|
Needs main merge + CI fix, code LG |
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
snowp
reviewed
May 24, 2021
Comment on lines
-15
to
18
| : context_(std::move(context)) {} | ||
| : context_(std::move(context)) { | ||
| ASSERT(context_.get()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this change belong here? Not opposed to it, just seems unrelated to the main change in this PR
There was a problem hiding this comment.
it was a follow-up to a change requested in another PR.
I can split it into its own thing, but didn't think it was worth the CI cost :-P
There was a problem hiding this comment.
Fine with me as long as we're aware that we're doing it!
snowp
previously approved these changes
May 24, 2021
Signed-off-by: Alyssa Wilk <[email protected]>
snowp
approved these changes
May 25, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Risk Level: Low (http/3 only) Testing: existing flow control tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: Low (http/3 only)
Testing: existing flow control tests pass
Docs Changes: n/a
Release Notes: n/a