Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Use entrypoint for distroless image #16383

Merged
merged 2 commits into from
May 20, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented May 7, 2021

Signed-off-by: Ryan Northey [email protected]

Commit Message: docker: Use entrypoint for distroless image
Additional Description:

Use an entrypoint rather than cmd for starting distroless container. Allows custom args to be passed through.

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax
Copy link
Member Author

phlax commented May 7, 2021

cc @oleksiyp

@phlax phlax requested a review from lizan May 7, 2021 17:40
@phlax
Copy link
Member Author

phlax commented May 7, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16383 (comment) was created by @phlax.

see: more, trace.

@phlax phlax requested a review from lizan May 18, 2021 10:34
phlax added 2 commits May 18, 2021 12:05
@phlax phlax force-pushed the docker-distroless-entrypoint branch from 344182d to 6f2c0be Compare May 18, 2021 11:07
@phlax phlax merged commit 17aa841 into envoyproxy:main May 20, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants