test: cleaning up unneeded helpers. #16334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
jmarantz
reviewed
May 5, 2021
| @@ -362,8 +362,8 @@ class HdsIntegrationTest : public Grpc::VersionedGrpcClientIntegrationParamTest, | |||
| FakeStreamPtr hds_stream_; | |||
| FakeUpstream* hds_upstream_{}; | |||
| uint32_t hds_requests_{}; | |||
| FakeUpstreamPtr host_upstream_{}; | |||
| FakeUpstreamPtr host2_upstream_{}; | |||
| FakeUpstream* host_upstream_{}; | |||
There was a problem hiding this comment.
add line comment on ownership
| // Creates a fake upstream bound to INADDR_ANY and there is no specified port. | ||
| std::unique_ptr<FakeUpstream> createFakeUpstream(FakeHttpConnection::Type type) { | ||
| // Add a fake upstream bound to INADDR_ANY and there is no specified port. | ||
| std::unique_ptr<FakeUpstream>& addFakeUpstream(FakeHttpConnection::Type type) { |
There was a problem hiding this comment.
maybe return FakeUpstream* or OptRef<FakeUpstream>
Signed-off-by: Alyssa Wilk <[email protected]>
yanavlasov
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a (test only)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a