-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protodoc: Add redirects for v2 protos to current version and links to old #16303
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
docs rendered here - https://storage.googleapis.com/envoy-pr/16303/docs/index.html |
8eb7427
to
28fd4dd
Compare
3165ba0
to
fb545f8
Compare
fabed64
to
c4b3a1e
Compare
f063b4a
to
230e00d
Compare
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
this PR now requires I have hacked it in here for now - but ive also raised a PR in envoy-build-tools to add envoyproxy/envoy-build-tools#132 there is alternately a bazel recipe i found here https://github.com/kythe/kythe/blob/master/third_party/jq.BUILD im happy to resolve in any of the above ways - as long as we can add it |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Code looks good. Looking at the docs, the box on the RHS is a bit of an eye sore. I know you are thinking of tabs here, is there any way to make the docs less cluttered before landing them? |
this is the best i could come up with before shifting things to tabs - it needs to work in a few different situtations this is far from ideal - but i would like to get this landed and then work on the tabs - which will take some time in terms of figuring out how best to render - im working on it already tho... |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
/retest |
Retrying Azure Pipelines: |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I think the current UX is fine for interim, looking forward to a tabs focused replacement.
/lgtm deps |
Commit Message: protodoc: Add redirects for v2 protos to current version and links to old
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #16297
[Optional Deprecated:]
[Optional API Considerations:]