docs: fix type_url for v3.TlsInspector #16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ch-plattner, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
hi @ch-plattner looks good - can you fix DCO please |
Signed-off-by: Charissa Sonder Plattner <[email protected]>
|
hi @phlax, thanks for the quick review! I fixed DCO |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 5, 2021
Signed-off-by: Charissa Sonder Plattner <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Signed-off-by: Charissa Sonder Plattner <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the type_url defined in this file made my bootstrap config invalid -- I believe this should be the correct type url based on https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/listener/tls_inspector/v3/tls_inspector.proto#extensions-filters-listener-tls-inspector-v3-tlsinspector!
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: docs: fix type_url for v3.TlsInspector
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]