ext_proc: Support clearing the route cache #16288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit Message: Support the clear_route_cache parameter on responses from the remote server Risk Level: Low. Only enabled if the flag is set. Testing: New unit test to ensure that the method is called. Docs Changes: Marked "clear_route_cache" in the API as no longer "not-implemented". Release Notes: If the clear_route_cache flag is set on a response from the external processing server, then the filter will call the "clearRouteCache" method on the filter state. Processors should set this flag if they have changed any headers, such as ":path", which may affect routing after the filter runs. Signed-off-by: Gregory Brail <[email protected]>
htuch
reviewed
May 4, 2021
| @@ -66,6 +69,9 @@ bool ProcessorState::handleBodyResponse(const BodyResponse& response) { | |||
| modifyBufferedData([this, &response](Buffer::Instance& data) { | |||
| MutationUtils::applyCommonBodyResponse(response, headers_, data); | |||
| }); | |||
| if (response.response().clear_route_cache()) { | |||
| filter_callbacks_->clearRouteCache(); | |||
There was a problem hiding this comment.
Since routing doesn't use the body, does it make sense to clear here?
There was a problem hiding this comment.
When the body is in buffered mode, it's possible to set headers when responding to the body callback, so it's possible that someone will want this.
lizan
approved these changes
May 4, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Commit Message: Support the clear_route_cache parameter on responses from the remote server Risk Level: Low. Only enabled if the flag is set. Testing: New unit test to ensure that the method is called. Docs Changes: Marked "clear_route_cache" in the API as no longer "not-implemented". Release Notes: If the clear_route_cache flag is set on a response from the external processing server, then the filter will call the "clearRouteCache" method on the filter state. Processors should set this flag if they have changed any headers, such as ":path", which may affect routing after the filter runs. Signed-off-by: Gregory Brail <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Commit Message: Support the clear_route_cache parameter on responses from the remote server Risk Level: Low. Only enabled if the flag is set. Testing: New unit test to ensure that the method is called. Docs Changes: Marked "clear_route_cache" in the API as no longer "not-implemented". Release Notes: If the clear_route_cache flag is set on a response from the external processing server, then the filter will call the "clearRouteCache" method on the filter state. Processors should set this flag if they have changed any headers, such as ":path", which may affect routing after the filter runs. Signed-off-by: Gregory Brail <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Support the clear_route_cache parameter on responses
from the remote server
Risk Level: Low. Only enabled if the flag is set.
Testing: New unit test to ensure that the method is called.
Docs Changes: Marked "clear_route_cache" in the API as no longer
"not-implemented".
Release Notes: If the clear_route_cache flag is set on a
response from the external processing server, then the filter will
call the "clearRouteCache" method on the filter state. Processors
should set this flag if they have changed any headers, such as
":path", which may affect routing after the filter runs.
Signed-off-by: Gregory Brail [email protected]