tools: allow generate_go_protobuf.py to skip syncing with go-control-… #16287
Conversation
…plane Currently, it also syncs them with go_control_plane, but it can be useful for local development work to be able to just generate the code Signed-off-by: James Mulcahy <[email protected]>
|
thanks @jamesmulcahy this looks good... |
tools/api/generate_go_protobuf.py
Outdated
| @@ -121,16 +121,24 @@ def updated(repo): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| parser = argparse.ArgumentParser(description='Generate Go protobuf files and sync with go-control-plane') | |||
| parser.add_argument('--skip_sync', action='store_true') | |||
There was a problem hiding this comment.
how about reversing this - ie --sync and store_false
hmm thats not going to work but we could keep store_true and update where its called in ci
There was a problem hiding this comment.
Yeah, that works. I've made the change locally. Would you prefer a commit on top, or re-writing the original commit. I'm not 100% sure what the policy is here
There was a problem hiding this comment.
once there are reviewers, its preferred not to rebase/force - sometimes personally i find it necessary, but best avoided
There was a problem hiding this comment.
Ack. Extra commit pushed! 👍
Signed-off-by: James Mulcahy <[email protected]>
tools/api/generate_go_protobuf.py
Outdated
| @@ -142,3 +140,5 @@ def updated(repo): | |||
| new_sha = changes[0] | |||
| write_revision_info(repo, new_sha) | |||
| publish_go_protobufs(repo, new_sha) | |||
| else: | |||
There was a problem hiding this comment.
nit: bail early - ie if not args.sync: print + return
then you can dedent the following code
There was a problem hiding this comment.
Good suggestion, extra commit pushed with those changes.
Signed-off-by: James Mulcahy <[email protected]>
Signed-off-by: James Mulcahy <[email protected]>
|
@phlax FYI. The python formatting ci check failed, so I had to push an extra commit to fix a line wrapping issue. That led to your approval being dropped. |
envoyproxy#16287) Currently, it also syncs them with go_control_plane, but it can be useful for local development work to be able to just generate the code Risk Level: Low Testing: I've manually invoked the scripted and tested out the code. The existing behavior is retained as the default. Signed-off-by: James Mulcahy <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
envoyproxy#16287) Currently, it also syncs them with go_control_plane, but it can be useful for local development work to be able to just generate the code Risk Level: Low Testing: I've manually invoked the scripted and tested out the code. The existing behavior is retained as the default. Signed-off-by: James Mulcahy <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Commit Message:
Currently, it also syncs them with go_control_plane, but it can be
useful for local development work to be able to just generate the
code
Additional Description:
Risk Level: Low
Testing: I've manually invoked the scripted and tested out the code. The existing behavior is retained as the default.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:] n/a
[Optional Fixes #Issue] n/a
[Optional Deprecated:] n/a
[Optional API Considerations:] n/a