dns_cache: Remove getCacheManager() #16273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanTheOptimist
force-pushed
the
getCacheManager
branch
from
63986a4 to
36f1641
Compare
Remove the function getCacheManager() which was declared in dns_cache.h, defined in dns_cache_manager_impl.cc and called in dns_cache_manager_impl.h. Instead, simply inline this method into DnsCacheManagerFactoryImpl::get() which was the only place it was called. Signed-off-by: Ryan Hamilton <[email protected]>
RyanTheOptimist
force-pushed
the
getCacheManager
branch
from
36f1641 to
3395bb7
Compare
|
Alyssa, hopefully this is a pretty trivial PR. The getCacheManager() function was pretty odd :) |
alyssawilk
approved these changes
May 3, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 5, 2021
dns_cache: Remove getCacheManager() Remove the function getCacheManager() which was declared in dns_cache.h, defined in dns_cache_manager_impl.cc and called in dns_cache_manager_impl.h. Instead, simply inline this method into DnsCacheManagerFactoryImpl::get() which was the only place it was called. Risk Level: Low Testing: N/A - no code behavior change Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
dns_cache: Remove getCacheManager() Remove the function getCacheManager() which was declared in dns_cache.h, defined in dns_cache_manager_impl.cc and called in dns_cache_manager_impl.h. Instead, simply inline this method into DnsCacheManagerFactoryImpl::get() which was the only place it was called. Risk Level: Low Testing: N/A - no code behavior change Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns_cache: Remove getCacheManager()
Remove the function getCacheManager() which was declared in dns_cache.h,
defined in dns_cache_manager_impl.cc and called in dns_cache_manager_impl.h.
Instead, simply inline this method into DnsCacheManagerFactoryImpl::get()
which was the only place it was called.
Risk Level: Low
Testing: N/A - no code behavior change
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A