wasm: fix support for non-cloneable Wasm runtimes. #16263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <[email protected]>
lizan
reviewed
May 4, 2021
| @@ -106,7 +106,8 @@ Wasm::Wasm(WasmConfig& config, absl::string_view vm_key, const Stats::ScopeShare | |||
| Wasm::Wasm(WasmHandleSharedPtr base_wasm_handle, Event::Dispatcher& dispatcher) | |||
| : WasmBase(base_wasm_handle, | |||
| [&base_wasm_handle]() { | |||
| return createWasmVm(base_wasm_handle->wasm()->wasm_vm()->runtime()); | |||
| return createWasmVm(absl::StrCat("envoy.wasm.runtime.", | |||
There was a problem hiding this comment.
how this fix non-cloneable runtimes?
There was a problem hiding this comment.
base_wasm_handle->wasm()->wasm_vm()->runtime() is part of Proxy-Wasm C++ Host, which returns "v8", etc.
createWasmVm(name) is Envoy's interface for Wasm Runtimes, which uses Envoy names "envoy.wasm.runtime.v8", etc.
As such, there was a mismatach when using this constructor (which is only used for non-cloneable runtimes, which we don't have right now), because calling createWasmVm("v8") returns "Failed to create Wasm VM using v8 runtime. Envoy was compiled without support for it", since that runtime name is unknown to Envoy.
lizan
approved these changes
May 4, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Signed-off-by: Piotr Sikora <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora [email protected]