-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mark matching API and related features as alpha #16210
Changes from 10 commits
7677de0
7f549fb
4a8325a
7c7b8d3
19d292b
1dc8ca4
57aa455
c5b2cd3
a4712bb
34290c9
4931d16
3684c37
7291160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,10 @@ In addition, the following conventions should be followed: | |
implementation. These indicate that the entity is not implemented in Envoy and the entity | ||
should be hidden from the Envoy documentation. | ||
|
||
* Use a `[#experimental:]` annotation in comments for messages that are considered experimental | ||
and are not subject to the threat model. This differs from the work-in-progress/alpha tagging | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need to update this comment given it's now alpha tagging :-) I think also worth calling out that things tagged alpha are not yet subject to the stable API policies and security release policies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm we still have extension level alpha tagging which differs from this alpha tag which is the only way to mark messages within core as alpha. What kind of change were you thinking about? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was trying to resolve the two, and have alpha tagging for extensions be functionally the same as alpha tagging for messages and fields, which is basically that both are WIP, not stable APIs and less trusted code. |
||
of extensions in that in can be applied to configuration within the core API. | ||
|
||
* Always use plural field names for `repeated` fields, such as `filters`. | ||
|
||
* Due to the fact that we consider JSON/YAML to be first class inputs, we cannot easily change a | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,11 @@ | |
Composite Filter | ||
================ | ||
|
||
.. attention:: | ||
|
||
The composite filter is experimental and is currently under active development. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. optional: experimental -> alpha here and below? |
||
Capabilities will be expanded over time and the configuration structures are likely to change. | ||
|
||
The composite filter allows delegating filter actions to a filter specified by a | ||
:ref:`match result <arch_overview_matching_api>`. The purpose of this is to allow different filters | ||
or filter configurations to be selected based on the incoming request, allowing for more dynamic | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,11 @@ | |
Matching API | ||
============ | ||
|
||
.. attention:: | ||
|
||
The matching API is experimental and is currently under active development. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: s/experimental/alpha/ |
||
Capabilities will be expanded over time and the configuration structures are likely to change. | ||
|
||
Envoy makes use of a :ref:`matching API <envoy_v3_api_msg_config.common.matcher.v3.Matcher>` | ||
to allow the various subsystems to express actions that should be performed based on incoming data. | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that generally alpha things weren't considered to be in the threat model. Maybe we should just tag this alpha instead?
@yanavlasov for thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets to my comment above #16210 (review). I think the issue is we can only tag as alpha at file level. @snowp points out that sometimes we want to tag at feature level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but can we call them both alpha, rather than alpha and experimental? Unless there are actual differences, but I think the description above could apply to either so I'd lean towards calling it alpha and shipping :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm good with more consistent terminology here, that helps reduce some of the confusion.