wasm: use in_vm_context_created_ flag for http contexts. #16202
Conversation
Signed-off-by: Takeshi Yoneda <[email protected]>
There was a problem hiding this comment.
Removed
http_request_started_and instead use thein_vm_context_created_in Proxy-Wasm C++ host since it has exactly the same meaning (indicating whetheronCreateis called or not). Network filter is already usingin_vm_context_created_.
It indicates that HTTP request was started, not that onCreate() was called, which is not necessairly the same thing, since the latter can happen without active HTTP request.
Note that this was originally in_vm_context_created_ (envoyproxy/envoy-wasm#521), but it was later changed to http_request_started_ (envoyproxy/envoy-wasm#538). Unfortunately, it's not clear from that PR why the change happened, since it's mixed with other changes and added as part of "Update tests" review commit (envoyproxy/envoy-wasm@6c08032).
Having said that, I think it's fine to merge this. Worst case, we can revert it and add regression tests if anything breaks.
|
Thanks for digging into the history!
Yeah, let's see how it goes. |
…16202) Removed http_request_started_ and instead use the in_vm_context_created_ in Proxy-Wasm C++ host since it has exactly the same meaning (indicating whether onCreate is called or not). Network filter is already using in_vm_context_created_. Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Removed
http_request_started_and instead use thein_vm_context_created_in Proxy-Wasm C++ host since it has exactly the same meaning (indicating whetheronCreateis called or not). Network filter is already usingin_vm_context_created_.Signed-off-by: Takeshi Yoneda [email protected]