docs: update zk proxy configuration yaml. #16184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
changed the title
|
hi @JaredTan95 can we move this config into a yaml file and use |
Ok, I will update soon. |
phlax
reviewed
Apr 27, 2021
docs/root/configuration/listeners/network_filters/zookeeper_proxy_filter.rst
Outdated
Show resolved
Hide resolved
phlax
reviewed
Apr 27, 2021
docs/root/configuration/listeners/network_filters/_include/zookeeper-proxy-filter.yaml
Outdated
Show resolved
Hide resolved
|
@JaredTan95 if you check the DCO docs you can have it added automatically to every commit https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#dco-sign-your-work |
phlax
reviewed
Apr 27, 2021
docs/root/configuration/listeners/network_filters/_include/zookeeper-proxy-filter.yaml
Outdated
Show resolved
Hide resolved
This PR updates our QUICHE dependency to commit 88c8d5903d851744410ea9840201b6507feae981. Signed-off-by: David Schinazi <[email protected]> Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: Peter Jausovec <[email protected]> Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: Asra Ali <[email protected]> Commit Message: Temporary CI fix before #16074 Risk Level: Low Testing: Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: JaredTan95 <[email protected]>
Signed-off-by: JaredTan95 <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
you might want to rebase and force push - merging is mangling commits |
|
I will open another PR to continue it. |
|
as you feel - rebase will work i think apologies for so much unrelated issues - you seem to have hit all the ci hurdles 8/ |
|
new PR:#16190 :-P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaredTan95 [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: update zk proxy configuration yaml.
Additional Description: update zk proxy configuration yaml.
Risk Level: N/A
Testing: N/A
Docs Changes: update zk proxy configuration yaml.
Release Notes: N/A
Platform Specific Features: N/A