Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config proto for Secure Session Agent (S2A) transport socket extension. #16183

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Config proto for Secure Session Agent (S2A) transport socket extension. #16183

merged 7 commits into from
Apr 30, 2021

Conversation

tavishvaidya
Copy link
Contributor

@tavishvaidya tavishvaidya commented Apr 26, 2021 •
edited
Loading

Config proto for Secure Session Agent (S2A) transport socket extension (#16110).

Signed-off-by: Tavish Vaidya [email protected]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #16183 was opened by tavishvaidya.

see: more, trace.

@tavishvaidya tavishvaidya marked this pull request as ready for review April 26, 2021 20:51
@tavishvaidya
Copy link
Contributor Author

/assign @asraa
/assign @cesarghali
/assign @matthewstevenson88

@repokitteh-read-only
Copy link

@cesarghali cannot be assigned to this issue.

🐱

Caused by: a #16183 (comment) was created by @tavishvaidya.

see: more, trace.

@repokitteh-read-only
Copy link

@matthewstevenson88 cannot be assigned to this issue.

🐱

Caused by: a #16183 (comment) was created by @tavishvaidya.

see: more, trace.

cesarghali
cesarghali previously approved these changes Apr 26, 2021
View reviewed changes
htuch
htuch suggested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few clarification asks.
/wait

api/envoy/extensions/transport_sockets/s2a/v3alpha/s2a.proto Outdated Show resolved Hide resolved
api/envoy/extensions/transport_sockets/s2a/v3alpha/s2a.proto Outdated Show resolved Hide resolved
api/envoy/extensions/transport_sockets/s2a/v3alpha/s2a.proto Show resolved Hide resolved
@phlax
Copy link
Member

phlax commented Apr 28, 2021

not sure why the docs (or rather protos) build is currently failing

would be good to check over the rendered api docs before merging

@phlax
Copy link
Member

phlax commented Apr 28, 2021

ah i see the failure is here https://dev.azure.com/cncf/envoy/_build/results?buildId=73604&view=logs&j=91e633a5-4907-5da1-5862-92a79fe2387a&t=f29e24e7-a093-5724-80bd-d79975d268cb&l=495

@tavishvaidya
Copy link
Contributor Author

tavishvaidya commented Apr 28, 2021 •
edited
Loading

ah i see the failure is here https://dev.azure.com/cncf/envoy/_build/results?buildId=73604&view=logs&j=91e633a5-4907-5da1-5862-92a79fe2387a&t=f29e24e7-a093-5724-80bd-d79975d268cb&l=495

From the presubmit log, "Did you forget to add 'envoy.transport_sockets.s2a' to source/extensions/extensions_build_config.bzl?" Well yes, but I am not touching anything under source/extensions/ in this PR. This will be added there in the future. So, maybe it is ok to ignore this error?

@phlax
Copy link
Member

phlax commented Apr 28, 2021

afaict this is what is causing the proto build (and subsequently the docs build) to fail - i think you need to add it

@tavishvaidya
Removes #extension: envoy.transport_sockets.s2a comment.
b0b657f 
* This was causing the protodoc presubmit to fail.

Signed-off-by: Tavish Vaidya <[email protected]>
htuch
htuch approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit abe2f9b into envoyproxy:main Apr 30, 2021
@tavishvaidya
Copy link
Contributor Author

Thank you everyone for the reviews!

@tavishvaidya tavishvaidya deleted the s2aProto branch April 30, 2021 18:15
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
@tavishvaidya
Config proto for Secure Session Agent (S2A) transport socket extensio…
174431b 
…n. (envoyproxy#16183)

Config proto for Secure Session Agent (S2A) transport socket extension (envoyproxy#16110).

Signed-off-by: Tavish Vaidya <[email protected]>
Signed-off-by: Gokul Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax left review comments

@asraa asraa asraa left review comments

@htuch htuch htuch approved these changes

@cesarghali cesarghali cesarghali left review comments

@matthewstevenson88 matthewstevenson88 matthewstevenson88 left review comments

Assignees

@asraa asraa

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tavishvaidya @phlax @cesarghali @asraa @htuch @matthewstevenson88