Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: Simplify example config and fix docs #16142

Merged
merged 7 commits into from
Apr 30, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 23, 2021

Signed-off-by: Ryan Northey [email protected]

Commit Message: wasm: Simplify example config and fix docs
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #15558
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax marked this pull request as draft April 23, 2021 12:20
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Apr 28, 2021

phlax added 2 commits April 29, 2021 10:42
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax marked this pull request as ready for review April 29, 2021 10:11
@phlax phlax changed the title [WIP] wasm: Simplify example config and fix docs wasm: Simplify example config and fix docs Apr 29, 2021
@phlax phlax requested a review from PiotrSikora April 30, 2021 07:43
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Apr 30, 2021

latest docs are here https://storage.googleapis.com/envoy-pr/16142/docs/index.html (as they are rendered)

Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yanavlasov yanavlasov merged commit 63307f5 into envoyproxy:main Apr 30, 2021
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in example config for WASM
3 participants