Minor fix: Fix protoleak.

[KBaichoo]

Signed-off-by: Kevin Baichoo [email protected]

Commit Message: Fixed proto leaks.
Additional Description: Let protos manage memory themselves vs explicitly handling it with set_foo and release_foo
Risk Level: Low
Testing: NA
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA

[KBaichoo]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16101 (comment) was created by @KBaichoo.

see: more, trace.

[KBaichoo]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16101 (comment) was created by @KBaichoo.

see: more, trace.

[akonradi]

I like the change but I think the description is wrong. The proto was only ever allocated on the stack, so using the set_allocated and release_ methods seems like the right way to prevent calls to delete that would have been erroneous. This is the correct fix though: letting protos manage memory themselves and accessing them through the normal API.

[KBaichoo]

Yep that's correct. We're dealing with raw pointers and ownership isn't explicit as using a smart ptr.

[KBaichoo]

Can I get a review @envoyproxy/maintainers ?

This is a minor fix to a test. Thanks!