-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rules_go to v0.27.0 (#16065) #16083
Conversation
Hi @QIvan, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
2ce5383
to
c1bc106
Compare
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed. It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986) Signed-off-by: Ivan Zemlyanskiy <[email protected]>
I've been running this in my environments since it was released |
Might be too late but might be good to bump the Go version to |
Signed-off-by: izemlyanskiy <[email protected]>
@moderation done (see the last commit) |
hmmmm... after go upgrade it complains like ERROR: /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/com_github_lyft_protoc_gen_star/BUILD.bazel:3:11: GoCompilePkg external/com_github_lyft_protoc_gen_star/protoc-gen-star.a failed (Exit 1): builder failed: error executing command
(cd /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy && \
exec env - \
CGO_ENABLED=1 \
GOARCH=amd64 \
GOOS=linux \
GOPATH='' \
GOROOT=external/go_sdk \
GOROOT_FINAL=GOROOT \
PATH=/opt/llvm/bin:/usr/bin:/bin \
bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/com_github_lyft_protoc_gen_star/artifact.go -src external/com_github_lyft_protoc_gen_star/ast.go -src external/com_github_lyft_protoc_gen_star/build_context.go -src external/com_github_lyft_protoc_gen_star/comment.go -src external/com_github_lyft_protoc_gen_star/debug.go -src external/com_github_lyft_protoc_gen_star/docs.go -src external/com_github_lyft_protoc_gen_star/entity.go -src external/com_github_lyft_protoc_gen_star/enum.go -src external/com_github_lyft_protoc_gen_star/enum_value.go -src external/com_github_lyft_protoc_gen_star/extension.go -src external/com_github_lyft_protoc_gen_star/field.go -src external/com_github_lyft_protoc_gen_star/field_type.go -src external/com_github_lyft_protoc_gen_star/field_type_elem.go -src external/com_github_lyft_protoc_gen_star/file.go -src external/com_github_lyft_protoc_gen_star/generator.go -src external/com_github_lyft_protoc_gen_star/init_option.go -src external/com_github_lyft_protoc_gen_star/message.go -src external/com_github_lyft_protoc_gen_star/method.go -src external/com_github_lyft_protoc_gen_star/module.go -src external/com_github_lyft_protoc_gen_star/name.go -src external/com_github_lyft_protoc_gen_star/node.go -src external/com_github_lyft_protoc_gen_star/oneof.go -src external/com_github_lyft_protoc_gen_star/package.go -src external/com_github_lyft_protoc_gen_star/parameters.go -src external/com_github_lyft_protoc_gen_star/persister.go -src external/com_github_lyft_protoc_gen_star/post_process.go -src external/com_github_lyft_protoc_gen_star/proto.go -src external/com_github_lyft_protoc_gen_star/service.go -src external/com_github_lyft_protoc_gen_star/source_code_info.go -src external/com_github_lyft_protoc_gen_star/wkt.go -src external/com_github_lyft_protoc_gen_star/workflow.go -arc 'github.com/golang/protobuf/proto=github.com/golang/protobuf/proto=bazel-out/host/bin/external/com_github_golang_protobuf/proto/proto.x' -arc 'github.com/golang/protobuf/protoc-gen-go/plugin=github.com/golang/protobuf/protoc-gen-go/plugin=bazel-out/host/bin/external/io_bazel_rules_go/proto/wkt/compiler_plugin_go_proto.x' -arc 'github.com/golang/protobuf/protoc-gen-go/descriptor=github.com/golang/protobuf/protoc-gen-go/descriptor=bazel-out/host/bin/external/io_bazel_rules_go/proto/wkt/descriptor_go_proto.x' -importpath github.com/lyft/protoc-gen-star -p github.com/lyft/protoc-gen-star -package_list bazel-out/host/bin/external/go_sdk/packages.txt -o bazel-out/host/bin/external/com_github_lyft_protoc_gen_star/protoc-gen-star.a -x bazel-out/host/bin/external/com_github_lyft_protoc_gen_star/protoc-gen-star.x -gcflags '' -asmflags '')
Execution platform: @rbe_ubuntu_clang_libcxx//config:platform
compilepkg: missing strict dependencies:
/b/f/w/external/com_github_lyft_protoc_gen_star/init_option.go: import of "github.com/spf13/afero"
/b/f/w/external/com_github_lyft_protoc_gen_star/persister.go: import of "github.com/spf13/afero"
No dependencies were provided. seems like it's not an easy change. I'll revert the last commit |
This reverts commit b91ea2d. Signed-off-by: izemlyanskiy <[email protected]>
I'm guessing this is a change in module handling in Go 1.16. I'm building the API and the binary and it works but it is with a subset of extensions compiled in. Can we bump to 1.15.11 which is the latest Go version that should be compatible? |
@moderation sorry, didn't get in time with the change... |
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed. It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986) Signed-off-by: izemlyanskiy <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed.
It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986)