Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: Add all pytests checker #16031

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 16, 2021

Signed-off-by: Ryan Northey [email protected]

Commit Message: tooling: Add all pytests checker
Additional Description:

another breakout from #15833

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title tooling: Add all pytests checker [WIP] tooling: Add all pytests checker Apr 16, 2021
@phlax phlax marked this pull request as draft April 16, 2021 11:01
@phlax
Copy link
Member Author

phlax commented Apr 19, 2021

@phlax phlax force-pushed the tooling-all-checkers branch from 5775881 to 2bbdb25 Compare April 20, 2021 11:10
phlax added 2 commits April 20, 2021 16:03
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the tooling-all-checkers branch from df92aab to 6df3b26 Compare April 20, 2021 15:05
phlax added 4 commits April 20, 2021 17:19
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax marked this pull request as ready for review April 20, 2021 17:29
@phlax phlax changed the title [WIP] tooling: Add all pytests checker tooling: Add all pytests checker Apr 20, 2021
@phlax phlax requested a review from htuch April 20, 2021 17:29
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small comments.
/wait

tools/base/runner.py Outdated Show resolved Hide resolved
tools/base/tests/test_runner.py Outdated Show resolved Hide resolved
tools/base/tests/test_runner.py Outdated Show resolved Hide resolved
Signed-off-by: Ryan Northey <[email protected]>
phlax added 2 commits April 22, 2021 10:32
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax requested a review from htuch April 22, 2021 10:28
call_args = (("--",) + args) if args else args
bazel_args = ("bazel", "run", "BAZEL RUN") + call_args
bazel_kwargs = {}
bazel_kwargs["capture_output"] = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= capture_output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is checking the default - ie unless its specifically set to True then it should False

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I probably would have gone with capture_output or False, but sure.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit.

self,
target: str,
*args,
capture_output: bool = False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie here

@phlax phlax requested a review from htuch April 22, 2021 16:21
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 15d71b0 into envoyproxy:main Apr 22, 2021
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
another breakout from envoyproxy#15833

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Gokul Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants