tls: remove legacy socket BIOs and runtime guard #16023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florin Coras <[email protected]>
Signed-off-by: Florin Coras <[email protected]>
Signed-off-by: Florin Coras <[email protected]>
Signed-off-by: Florin Coras <[email protected]>
Signed-off-by: Florin Coras <[email protected]>
ggreenway
previously approved these changes
Apr 19, 2021
|
/wait |
Signed-off-by: Florin Coras <[email protected]>
|
Merged main so conflict should be solved now. As for the test, this should not change default logic, so could it be a flake? |
Yeah, could be a flake. Let's see what happens with this CI run. |
ggreenway
approved these changes
Apr 19, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
* tls: remove legacy socket BIOs and runtime guard Signed-off-by: Florin Coras <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florin Coras [email protected]
Fixes #16013
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: removed envoy.reloadable_features.tls_use_io_handle_bio runtime guard