Use RELEASE_ASSERT instead of raise(SIGABRT) in kill_request filter #15999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ Http::FilterHeadersStatus KillRequestFilter::encodeHeaders(Http::ResponseHeaderM | |||
|
|
|||
| if (isKillRequest(headers) && isKillRequestEnabled()) { | |||
| // Crash Envoy. | |||
| raise(SIGABRT); | |||
| RELEASE_ASSERT(false, "KillRequestFilter is crashing Envoy!!!"); | |||
There was a problem hiding this comment.
Should we consider adding some EXPECT_DEATH tests that look for the message above when terminating the process due to use of this filter?
There was a problem hiding this comment.
I think these death tests are already there in the kill_request_filter_test.cc
There was a problem hiding this comment.
Right. My request is to change expectations like:
EXPECT_DEATH(filter_->decodeHeaders(request_headers_, false), "");
to:
EXPECT_DEATH(filter_->decodeHeaders(request_headers_, false), "KillRequestFilter is crashing Envoy!!!");
There was a problem hiding this comment.
thanks. Updated the test.
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…quest filter (envoyproxy#15999) Signed-off-by: [email protected] <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Use
RELEASE_ASSERTinstead ofraise(SIGABRT)in kill_request filter to provide better logging when the filter is crashing Envoy.Additional Description: N/A
Risk Level: low
Testing: unit test, integration test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
/assign @antoniovicente