RaiiMapOfListElement: fix invalid reference due to rehashing instability #15719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2021 18:54
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
junr03
commented
Mar 26, 2021
| : map_(map), list_(map_.try_emplace(key).first->second), key_(key), cancelled_(false) { | ||
| it_ = list_.emplace(list_.begin(), value); | ||
| : map_(map), key_(key), cancelled_(false) { | ||
| // The list reference itself cannot be saved because it is not stable in the event of a |
There was a problem hiding this comment.
note: an alternative fix is to use absl::node_hash_map. I went ahead with this fix because it doesn't require usage site changes, and abseil generally recommends using flat_hash_map, over node_hash_map unless it's necessary.
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: fix invalid reference due to rehashing instability.
Risk Level: low - fixed repro.
Testing: new test to repro original issue.