Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_clang_tidy.sh to support bazel targets with '@repository' prefixes #15604

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Update run_clang_tidy.sh to support bazel targets with '@repository' prefixes #15604

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c691d7
Update run_clang_tidy.sh to support repository
murray-stripe Mar 22, 2021
31214f0
remove array expansion
murray-stripe Mar 22, 2021
778c01f
PR Feedbac - use read + array expansion
murray-stripe Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/run_clang_tidy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ echo "Generating compilation database..."

# bazel build need to be run to setup virtual includes, generating files which are consumed
# by clang-tidy
"${ENVOY_SRCDIR}/tools/gen_compilation_database.py" --include_headers
read -ra COMP_DB_TARGETS <<< "$COMP_DB_TARGETS"
"${ENVOY_SRCDIR}/tools/gen_compilation_database.py" --include_headers "${COMP_DB_TARGETS[@]}"

# Do not run clang-tidy against win32 impl
# TODO(scw00): We should run clang-tidy against win32 impl once we have clang-cl support for Windows
Expand Down