quic: moving helpers to be shared by connection pool #15444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
danzh2010
previously approved these changes
Mar 11, 2021
| virtual std::unique_ptr<Network::ClientConnection> | ||
| createQuicNetworkConnection(Network::Address::InstanceConstSharedPtr server_addr, | ||
| Network::Address::InstanceConstSharedPtr local_addr, | ||
| // Allows thread-local creation of PersistentQuicInfo. |
There was a problem hiding this comment.
I can understand this object is per-conn pool. But is it thread-local?
Plz add comment how to use these interfaces to create a client connection.
There was a problem hiding this comment.
connection pools must be thread local (they're not thread safe). will comment :-)
Signed-off-by: Alyssa Wilk <[email protected]>
mattklein123
previously approved these changes
Mar 11, 2021
| Network::TransportSocketFactory& transport_socket_factory = host->transportSocketFactory(); | ||
| quic_info_ = | ||
| Config::Utility::getAndCheckFactoryByName<Http::QuicClientConnectionFactory>( | ||
| Http::QuicCodecNames::get().Quiche) |
There was a problem hiding this comment.
example of cross dependency issue that we were discussing in the slack thread (so yeah, I think I'm firmly in the no extension camp now!)
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
mattklein123
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO and also the tsan issues triggered with the last merge.
Risk Level: n/a (quic upstream only)
Testing: integration tests
Docs Changes: n/a
Release Notes: n/a