backport 1.16: container: Only drop privs if user is root (#15115)

[Shikugawa]

Signed-off-by: Ryan Northey [email protected]
Signed-off-by: Shikugawa [email protected]

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

[phlax]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15398 (comment) was created by @phlax.

see: more, trace.

[phlax]

lgtm

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[phlax]

@Shikugawa afaict this hasnt been merged to the 1.16 branch yet - is that correct ?

[Shikugawa]

@lizan Could you approve this?

[phlax]

@dmitri-d it would be great if we can add this to the 1.16 branch as i think it was causing some users (openshift users iirc) some pain

@lizan any objections on backporting this ?

[dmitri-d]

it would be great if we can add this to the 1.16 branch

@phlax: did you mean another branch? This PR is against 1.16...

[phlax]

@phlax: did you mean another branch? This PR is against 1.16...

im thinking it would be helpful to backport it to 1.16 - not sure why it didnt land before

i think the original reporter had issue on 1.17, but i think this would be helpful more generally (see #14141 for discussion)

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!