Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: allow using empty vm_id to indicate the current WasmVM. #15359

Merged
merged 3 commits into from
Mar 29, 2021
Merged

wasm: allow using empty vm_id to indicate the current WasmVM. #15359

merged 3 commits into from
Mar 29, 2021

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora PiotrSikora requested a review from lizan as a code owner March 8, 2021 07:37
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15359 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 8, 2021
mathetake
mathetake approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiotrSikora
Copy link
Contributor Author

@moderation PTAL for deps.

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 10, 2021
@PiotrSikora
Copy link
Contributor Author

@lizan PTAL.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 24, 2021
@PiotrSikora
Copy link
Contributor Author

/lgtm deps

This was lost after the merge with the main branch. @moderation could you approve again? Thanks!

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 24, 2021
@lizan lizan merged commit 87f9309 into envoyproxy:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

@lizan lizan lizan approved these changes

@moderation moderation moderation approved these changes

Assignees

@mathetake mathetake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiotrSikora @moderation @lizan @mathetake