-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation note for features not supported on Windows #15298
Conversation
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
@envoyproxy/windows-dev do you think we should leave the issue open for extra documentation or close the issue with this PR? |
Also chime in with other features that you know that they are not working on Windows |
Sorry, cI was having some issues yesterday - can you do a main merge? |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Awesome, LGTM from a docs perspective but I'd like one of the @envoyproxy/windows-dev (@wrowe ? ) to sign off for correctness :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember, these notes sound correct 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level comment: this kind of thing will inevitably get out of date. This is fine for now but can we work towards codifying this in source code probably via a bazel tag that is then used to render extension specific documentation like we are now starting to do elsewhere? It would be nice to open a tracking issue on this.
cc @phlax @davinci26
Commit Message:
Adds note in the docs for features that are not supported on Windows
See #13322
Risk Level: N/A
Testing: N/A
Docs Changes: Only docs
Release Notes: N/A