Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation note for features not supported on Windows #15298

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

davinci26
Copy link
Member

Commit Message:
Adds note in the docs for features that are not supported on Windows
See #13322

Risk Level: N/A
Testing: N/A
Docs Changes: Only docs
Release Notes: N/A

Sotiris Nanopoulos added 2 commits March 3, 2021 15:47
Signed-off-by: Sotiris Nanopoulos <[email protected]>
@davinci26
Copy link
Member Author

@envoyproxy/windows-dev do you think we should leave the issue open for extra documentation or close the issue with this PR?

@davinci26
Copy link
Member Author

Also chime in with other features that you know that they are not working on Windows

@davinci26 davinci26 changed the title Win32docsimprovements Adds documentation note for features on supported on Windows Mar 4, 2021
@davinci26 davinci26 changed the title Adds documentation note for features on supported on Windows Adds documentation note for features not supported on Windows Mar 4, 2021
@alyssawilk
Copy link
Contributor

Sorry, cI was having some issues yesterday - can you do a main merge?

@alyssawilk
Copy link
Contributor

Awesome, LGTM from a docs perspective but I'd like one of the @envoyproxy/windows-dev (@wrowe ? ) to sign off for correctness :-)

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, these notes sound correct 👍🏽

@alyssawilk alyssawilk merged commit 24fb26b into envoyproxy:main Mar 8, 2021
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level comment: this kind of thing will inevitably get out of date. This is fine for now but can we work towards codifying this in source code probably via a bazel tag that is then used to render extension specific documentation like we are now starting to do elsewhere? It would be nice to open a tracking issue on this.

cc @phlax @davinci26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants