Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_log: Fix substition formatter to recognize commands containing integers #15256

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

derekargueta
Copy link
Member

Fixes #15255

Signed-off-by: Derek Argueta [email protected]

@derekargueta derekargueta changed the title Fix substition formatter to recognize commands containing integers access_log: Fix substition formatter to recognize commands containing integers Mar 2, 2021
zuercher
zuercher previously approved these changes Mar 2, 2021
@derekargueta
Copy link
Member Author

gah messed up my git history when forgetting to sign, sorry for the force push

@derekargueta derekargueta force-pushed the substition-formatter-fix branch from 9c11db2 to 1f439c0 Compare March 2, 2021 21:18
@zuercher zuercher merged commit 671e436 into envoyproxy:main Mar 3, 2021
@derekargueta derekargueta deleted the substition-formatter-fix branch March 3, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substition Formatter won't accept %DOWNSTREAM_PEER_FINGERPRINT_256% or %DOWNSTREAM_PEER_FINGERPRINT_1%
2 participants