Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: avoid double hashing of protos in CDS init #15241

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

rojkov
Copy link
Member

@rojkov rojkov commented Mar 1, 2021

Commit Message: upstream: avoid double hashing of protos in CDS init
Additional Description:
Currently Cluster messages are hashed unconditionally upon instantiation of ClusterManagerImpl::ClusterData even if their hashes are known already.
Calculate the hashes outside of ClusterManagerImpl::ClusterData ctor to make use of already calculated ones.
Risk Level: Low
Testing: unit tests, manual tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Contributes to #12138

@alyssawilk alyssawilk self-assigned this Mar 1, 2021
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM but given all your improvements in this space what do you think about adding a benchmark (and/or commenting benchmark improvements in the perf PRs)?

@yanavlasov
Copy link
Contributor

code LGTM but given all your improvements in this space what do you think about adding a benchmark (and/or commenting benchmark improvements in the perf PRs)?

I'm planning to take over and complete PR #14167 for adding benchmarks. This is actually quite visible on internal CPU profiles at 7%.

@yanavlasov yanavlasov self-assigned this Mar 2, 2021
@alyssawilk alyssawilk merged commit d812443 into envoyproxy:main Mar 2, 2021
@rojkov rojkov deleted the cds-double-hash-v2 branch March 2, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants