Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve error message for docs #14817

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

auni53
Copy link
Contributor

@auni53 auni53 commented Jan 25, 2021

Risk Level: Low
Testing: N/A (script only)

Signed-off-by: Auni Ahsan <[email protected]>
@auni53
Copy link
Contributor Author

auni53 commented Jan 26, 2021

@alyssawilk @asraa moved this fix from the other PR.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-kicked. LGTM!

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for following up with this one!

@yanavlasov yanavlasov merged commit cafccb2 into envoyproxy:main Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants