-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions: Add extension categories in envoy_cc_extension #14744
Conversation
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@htuch hopefully this is doing the right thing - at least so far. to figure out the categories i have used the following command: $ git grep "std::string category() const override " | cut -d' ' -f9 | xargs -I{} bash -c "X={} echo \${X}" | sort | uniq
envoy.access_logger.extension_filters
envoy.access_loggers
envoy.bootstrap
envoy.clusters
envoy.compression.compressor
envoy.compression.decompressor
envoy.dubbo_proxy.filters
...
hopefully this is the ~canonical way to derive the categories. ill start matching them now... |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@htuch apologies for delay on this, i was fighting starlark syntax. i think this is ready for final review. the only one left with |
Signed-off-by: Ryan Northey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo TODOs and resolving the SSL implementation status with @lizan.
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@htuch this should be gtg once tests have passed |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
"envoy.guarddog_actions", | ||
"envoy.health_checkers", | ||
"envoy.internal_redirect_predicates", | ||
"envoy.io_socket", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@htuch i have added envoy.io_socket
category reflecting what was in the source/extensions/extensions_build_config.bzl
file
afaict there is not a factory for it tho, not sure of the implications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
/retest |
Retrying Azure Pipelines: |
Commit Message: extensions: Add extension categories in envoy_cc_extension
Additional Description:
This is a breakout PR from #14721
atm it just marks the category as
SOMECAT
as a marker. I will go through and add correct categories...Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]