Fix fake_upstreams_ index for xds_upstream_ in tests #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fake_upstreams_ could have more or less than 2 elements depending on fake_upstream_count_ Signed-off-by: Taylor Barrella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Fix fake_upstreams_ index for xds_upstream_ in tests
fake_upstreams_ could have more or less than 2 elements depending on fake_upstream_count_
Signed-off-by: Taylor Barrella [email protected]
Additional Description: See
createUpstreams()inBaseIntegrationTest::initialize()Risk Level: Low
Testing: Run integration tests that set
fake_upstream_count_!= 2 (protocol_integration_test and tcp_proxy_integration_test)Docs Changes: N/A
Release Notes: N/A