Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conn_pool] fix use after free in H/1 connection pool #14220

Merged
merged 17 commits into from
Dec 8, 2020
Merged

[conn_pool] fix use after free in H/1 connection pool #14220

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b48aee6
fix
asraa Nov 30, 2020
715df95
Revert "fix"
asraa Nov 30, 2020
e0338ad
update fix
asraa Dec 1, 2020
56e2f13
address comments, tcp test wip
asraa Dec 1, 2020
906c83f
fix h/1 test
asraa Dec 2, 2020
cd767c0
revert tcp
asraa Dec 2, 2020
2c34439
fix tcp test
asraa Dec 2, 2020
14004b0
remove extraneous tcp comment
asraa Dec 2, 2020
e75320f
make mock strict
asraa Dec 2, 2020
5f1d062
fix docker test
asraa Dec 2, 2020
6540549
fix asan
asraa Dec 3, 2020
d0b08e3
avoid recursing in clearDeferredDeleteList
asraa Dec 4, 2020
2b76b52
fix comment
asraa Dec 4, 2020
fac261a
fix spelling
asraa Dec 4, 2020
43e3cad
add default keyword
asraa Dec 5, 2020
2247fae
simplify
asraa Dec 5, 2020
b6304a4
make private
asraa Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/common/conn_pool/conn_pool_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,6 @@ class ConnPoolImplBase : protected Logger::Loggable<Logger::Id::pool> {
// Clients that are not ready to handle additional streams because they are CONNECTING.
std::list<ActiveClientPtr> connecting_clients_;

void onUpstreamReady();
Event::SchedulableCallbackPtr upstream_ready_cb_;

private:
std::list<PendingStreamPtr> pending_streams_;

Expand All @@ -253,6 +250,9 @@ class ConnPoolImplBase : protected Logger::Loggable<Logger::Id::pool> {
// The number of streams that can be immediately dispatched
// if all CONNECTING connections become connected.
uint32_t connecting_stream_capacity_{0};

void onUpstreamReady();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Usual ordering of elements in the private section according to style guide is:

  • classes/structs
  • functions
  • data members

Event::SchedulableCallbackPtr upstream_ready_cb_;
};

} // namespace ConnectionPool
Expand Down